Include function annotations in request attribute #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
dewantawsif
force-pushed
the
chore/annotations
branch
from
c8bbdd2 to
2868a6a
Compare
|
@Foso sorry for being impatient but can I have this looked at and merged? |
Foso
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Hi @dewantawsif thank you for your pull request! I looked at it, but for me it's not working. I can only find the annotations from Ktorfit and nothing else. Also please write a test for the code generation
|
Hi @Foso I've did my own testing and even looked at the generated code and everything seems to be working fine. But I did notice that you've added the annotation to If this isn't the issue please let me know the steps you took to test the code so I could try to reproduce. |
|
I changed the file name 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #751
🤔 DOD Checklist